HomePhabricator

[backport#19464] net: remove -banscore configuration option

Description

[backport#19464] net: remove -banscore configuration option

Summary:
06059b0c2a6c2db70c87a7715f8a344a13400fa1 net: rename DEFAULT_BANSCORE_THRESHOLD to DISCOURAGEMENT_THRESHOLD (Jon Atack)
1d4024bca8086cceff7539dd8c15e0b7fe1cc5ea net: remove -banscore configuration option (Jon Atack)

Pull request description:

per https://github.com/bitcoin/bitcoin/pull/19219#issuecomment-652684340, https://github.com/bitcoin/bitcoin/pull/19219#discussion_r443074487 and https://github.com/bitcoin/bitcoin/pull/19219#issuecomment-652699592. Edit: now split into 3 straightforward PRs:
- net: remove -banscore configuration option (this PR)
- rpc: deprecate banscore field in getpeerinfo (#19469, *merged*)
- gui: no longer display banscores (TBA in the gui repo)

Backport of Core PR19464

Depends on D8798

Test Plan:

ninja all check check-functional

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D8799

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on Jul 14 2020, 06:13
majcostaCommitted on Jan 6 2021, 09:15
majcostaPushed on Jan 6 2021, 09:15
Reviewer
Restricted Project
Differential Revision
D8799: [backport#19464] net: remove -banscore configuration option
Parents
rABCa40a553f0488: [backport#19469] rpc: deprecate banscore field in getpeerinfo
Branches
Unknown
Tags
Unknown