Page MenuHomePhabricator
Differential D8798

[backport#19469] rpc: deprecate banscore field in getpeerinfo
ClosedPublic
Actions

Authored by majcosta on Jan 5 2021, 21:44.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCa40a553f0488: [backport#19469] rpc: deprecate banscore field in getpeerinfo
Summary

41d55d30579358c805036201664ad6a1c1d48681 doc: getpeerinfo banscore deprecation release note (Jon Atack)
dd54e3796e633cfdf6954af306afd26eadc25116 test: getpeerinfo banscore deprecation test (Jon Atack)
8c7647b3fbbab03ea84071cf3cd2d0d2bf8be255 rpc: deprecate banscore field in rpc getpeerinfo (Jon Atack)

Pull request description:

Per https://github.com/bitcoin/bitcoin/pull/19219#discussion_r443074487 and https://github.com/bitcoin/bitcoin/pull/19219#issuecomment-652699592, this PR deprecates returning the `banscore` field in the `getpeerinfo` RPC, updates the help, adds a test, and updates the release notes. Related to #19464.

Backport of Core PR19469

Test Plan
ninja all check
test_runner rpc_getpeerinfo_banscore_deprecation

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jan 5 2021, 21:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 5 2021, 21:44
majcosta requested review of this revision.Jan 5 2021, 21:44
teamcity edited the summary of this revision. (Show Details)Jan 5 2021, 21:44
Harbormaster completed remote builds in B14579: Diff 26646.Jan 5 2021, 21:56
majcosta added a child revision: D8799: [backport#19464] net: remove -banscore configuration option.Jan 5 2021, 21:59
PiRK accepted this revision.Jan 6 2021, 08:43
PiRK added a subscriber: PiRK.

The code looks good to me. I don't have enough knowledge of banscore to have an opinion on the deprecation plan.

This revision is now accepted and ready to land.Jan 6 2021, 08:43
Closed by commit rABCa40a553f0488: [backport#19469] rpc: deprecate banscore field in getpeerinfo (authored by fanquake <fanquake@gmail.com>, committed by majcosta). · Explain WhyJan 6 2021, 09:16
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCa40a553f0488: [backport#19469] rpc: deprecate banscore field in getpeerinfo.
PiRK mentioned this in D8949: net: limit BIP37 filter lifespan (active between 'filterload'..'filterclear').Jan 18 2021, 22:27
PiRK mentioned this in rABC2e6177c0ef87: net: limit BIP37 filter lifespan (active between 'filterload'..'filterclear').Jan 19 2021, 08:58

Revision Contents
Changeset List

PathSize
doc/
4 lines
src/
rpc/
9 lines
test/
functional/
26 lines

Diff 26663

View Options

doc/release-notes.md

Loading...
View Options

src/rpc/net.cpp

Loading...
View Options

test/functional/rpc_getpeerinfo_banscore_deprecation.py

Loading...