Differential D8800

[backport#19512] p2p: banscore updates to gui, tests, release notes
ClosedPublic
Actions

Authored by majcosta on Jan 5 2021, 22:27.

Tags

None

Subscribers

Details

Reviewers

PiRK
Fabien

Group Reviewers

Restricted Project

Commits

rABC59fd163cc4f2: [backport#19512] p2p: banscore updates to gui, tests, release notes

Summary

fa108d6a757838225179a8df942cfb6d99c98c90 test: update tests for peer discouragement (Jon Atack)
1a9f462caa63fa16d7b4415312d2032a42b3fe0b gui, doc: rm Ban Score in GUI Peers window/release notes updates (Jon Atack)

Pull request description:

This is the third `-banscore` PR in the mini-series described in #19464. See that PR for the intention and reasoning.

- no longer display "Ban Score" in the GUI peers window and add a release note, plus release note fixups per https://github.com/bitcoin/bitcoin/pull/19464#pullrequestreview-447452052
- update tests (`src/test/denialofservice_tests.cpp` and `test/functional/p2p_leak.py`) from banning to discouragement and per https://github.com/bitcoin/bitcoin/pull/19464#issuecomment-658052518

Backport of Core PR19512

Depends on D8799

Test Plan

ninja all check check-functional

run bitcoin-qt on testnet mode, open Peers window, click a peer and see
that Banscore is no longer reported

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Jan 5 2021, 22:27

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 5 2021, 22:27

majcosta requested review of this revision.Jan 5 2021, 22:27

teamcity edited the summary of this revision. (Show Details)Jan 5 2021, 22:28

Harbormaster completed remote builds in B14581: Diff 26648.Jan 5 2021, 22:41

~~couldn't reproduce the error at all, don't think it's related to the diff~~

Harbormaster completed remote builds in B14583: Diff 26651.Jan 6 2021, 05:50

PiRK accepted this revision.Jan 6 2021, 08:54

PiRK added a subscriber: PiRK.

PiRK added inline comments.

src/test/denialofservice_tests.cpp
301 ↗	(On Diff #26651)	Same line comments

This revision is now accepted and ready to land.Jan 6 2021, 08:54

Fabien accepted this revision.Jan 6 2021, 08:57

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/test/denialofservice_tests.cpp
302 ↗	(On Diff #26651)	Nit: make it a single comment on its own line

Closed by commit rABC59fd163cc4f2: [backport#19512] p2p: banscore updates to gui, tests, release notes (authored by Wladimir J. van der Laan <laanwj@protonmail.com>, committed by majcosta). · Explain WhyJan 6 2021, 09:16

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC59fd163cc4f2: [backport#19512] p2p: banscore updates to gui, tests, release notes.

Revision Contents
Changeset List

Path

Size

doc/

release-notes.md

7 lines

src/

qt/

forms/

57 lines

4 lines

test/

denialofservice_tests.cpp

65 lines

test/

functional/

24 lines

Diff 26665

doc/release-notes.md

Loading...

src/qt/forms/debugwindow.ui

Loading...

src/qt/rpcconsole.cpp

Loading...

src/test/denialofservice_tests.cpp

Loading...

test/functional/p2p_leak.py

Loading...