Differential D8799

[backport#19464] net: remove -banscore configuration option
ClosedPublic
Actions

Authored by majcosta on Jan 5 2021, 21:59.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC91502b3998ac: [backport#19464] net: remove -banscore configuration option

Summary

06059b0c2a6c2db70c87a7715f8a344a13400fa1 net: rename DEFAULT_BANSCORE_THRESHOLD to DISCOURAGEMENT_THRESHOLD (Jon Atack)
1d4024bca8086cceff7539dd8c15e0b7fe1cc5ea net: remove -banscore configuration option (Jon Atack)

Pull request description:

per https://github.com/bitcoin/bitcoin/pull/19219#issuecomment-652684340, https://github.com/bitcoin/bitcoin/pull/19219#discussion_r443074487 and https://github.com/bitcoin/bitcoin/pull/19219#issuecomment-652699592. Edit: now split into 3 straightforward PRs:
- net: remove -banscore configuration option (this PR)
- rpc: deprecate banscore field in getpeerinfo (#19469, *merged*)
- gui: no longer display banscores (TBA in the gui repo)

Backport of Core PR19464

Depends on D8798

Test Plan

ninja all check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Jan 5 2021, 21:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 5 2021, 21:59

majcosta requested review of this revision.Jan 5 2021, 21:59

teamcity edited the summary of this revision. (Show Details)Jan 5 2021, 22:00

Harbormaster completed remote builds in B14580: Diff 26647.Jan 5 2021, 22:08

Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: wallet_descriptor.py ======

------- Stdout: -------
2021-01-05T22:07:00.875000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20210105_220418/wallet_descriptor_245
2021-01-05T22:07:01.404000Z TestFramework (INFO): Making a descriptor wallet
2021-01-05T22:07:01.614000Z TestFramework (INFO): Checking wallet info
2021-01-05T22:07:01.615000Z TestFramework (INFO): Test that getnewaddress and getrawchangeaddress work
2021-01-05T22:07:03.802000Z TestFramework (INFO): Test sending and receiving
2021-01-05T22:07:03.948000Z TestFramework (INFO): Test disabled RPCs
2021-01-05T22:07:04.137000Z TestFramework (INFO): Test encryption
2021-01-05T22:07:04.950000Z TestFramework (INFO): Test that getnewaddress still works after keypool is exhausted in an encrypted wallet
2021-01-05T22:07:14.815000Z TestFramework (INFO): Test that unlock is needed when deriving only hardened keys in an encrypted wallet
2021-01-05T22:07:14.923000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 120, in main
    self.run_test()
  File "/work/test/functional/wallet_descriptor.py", line 129, in run_test
    "active": True
  File "/work/test/functional/test_framework/coverage.py", line 48, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 159, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: Error: Please enter the wallet passphrase with walletpassphrase first. (-13)
2021-01-05T22:07:14.974000Z TestFramework (INFO): Stopping nodes
2021-01-05T22:07:15.226000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20210105_220418/wallet_descriptor_245
2021-01-05T22:07:15.226000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20210105_220418/wallet_descriptor_245/test_framework.log
2021-01-05T22:07:15.226000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20210105_220418/wallet_descriptor_245' to consolidate all logs

Each failure log is accessible here:
Bitcoin ABC functional tests: wallet_descriptor.py

majcosta added a child revision: D8800: [backport#19512] p2p: banscore updates to gui, tests, release notes.Jan 5 2021, 22:27

investigating failure

couldn't reproduce the error

Harbormaster completed remote builds in B14584: Diff 26652.Jan 6 2021, 08:10

PiRK accepted this revision.Jan 6 2021, 08:49

This revision is now accepted and ready to land.Jan 6 2021, 08:49

Closed by commit rABC91502b3998ac: [backport#19464] net: remove -banscore configuration option (authored by MarcoFalke <falke.marco@gmail.com>, committed by majcosta). · Explain WhyJan 6 2021, 09:16

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC91502b3998ac: [backport#19464] net: remove -banscore configuration option.