HomePhabricator

[backport#17445] zmq: Fix due to invalid argument and multiple notifiers

Description

[backport#17445] zmq: Fix due to invalid argument and multiple notifiers

Summary:
zmq: Fix due to invalid argument and multiple notifiers (João Barbosa)

Pull request description:

ZMQ initialization is interrupted if any notifier fails, and in that case all notifiers are destroyed. The notifier shutdown assumes that the initialization had occurred. This is not valid when there are multiple notifiers and any except the last fails to initialize.

Can be tested by running test/functional/interface_zmq.py from this branch with bitcoind from master.

Closes #17185.

Depends on D7341

Backport of Core PR17445

Test Plan:

ninja
./test/functional/test_runner.py interface_zmq

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D7345

Details

Provenance
Wladimir J. van der Laan <laanwj@protonmail.com>Authored on Jan 8 2020, 14:19
majcostaCommitted on Sep 3 2020, 21:40
majcostaPushed on Sep 3 2020, 21:40
Reviewer
Restricted Project
Differential Revision
D7345: [backport#17445] zmq: Fix due to invalid argument and multiple notifiers
Parents
rABCe516d58d922e: [backport#16598] test: Remove confusing hash256 function in util
Branches
Unknown
Tags
Unknown