Page MenuHomePhabricator
Differential D7341

[backport#16598] test: Remove confusing hash256 function in util
ClosedPublic
Actions

Authored by majcosta on Sep 3 2020, 17:59.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCe516d58d922e: [backport#16598] test: Remove confusing hash256 function in util
Summary

Moved and renamed hash256 from util.py to zmq_interface.py (Elichai Turkel)

Pull request description:

Right now there are two `hash256(bytes)` in the test framework:
first: https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/util.py#L186
second: https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/messages.py#L60

While they have the same name they're actually doing different things, one just does a sha256d and the other sha256d and reverses the bytes.
so I renamed the second one to be `hash256r` to signify that it's hash256 reversed.

Depends on D7344

Backport of Core PR16598

Test Plan
ninja check-functional
./test/functional/test_runner.py interface_zmq

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Sep 3 2020, 17:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 3 2020, 17:59
majcosta requested review of this revision.Sep 3 2020, 17:59
teamcity edited the summary of this revision. (Show Details)Sep 3 2020, 17:59

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12590: Diff 23242.Sep 3 2020, 18:03
majcosta added a child revision: D7342: [backport#16404] doc: Add note regarding ZMQ block notification.Sep 3 2020, 18:03
teamcity added a comment.Sep 3 2020, 18:04
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Snippet of first build failure:

wallet_hd.py                            | ○ Skipped | 0 s
wallet_import_rescan.py                 | ○ Skipped | 0 s
wallet_import_with_label.py             | ○ Skipped | 0 s
wallet_importmulti.py                   | ○ Skipped | 0 s
wallet_importprunedfunds.py             | ○ Skipped | 0 s
wallet_keypool.py                       | ○ Skipped | 0 s
wallet_keypool_topup.py                 | ○ Skipped | 0 s
wallet_labels.py                        | ○ Skipped | 0 s
wallet_listreceivedby.py                | ○ Skipped | 0 s
wallet_listsinceblock.py                | ○ Skipped | 0 s
wallet_listtransactions.py              | ○ Skipped | 0 s
wallet_multiwallet.py                   | ○ Skipped | 0 s
wallet_multiwallet.py --usecli          | ○ Skipped | 0 s
wallet_reorgsrestore.py                 | ○ Skipped | 0 s
wallet_resendwallettransactions.py      | ○ Skipped | 0 s
wallet_txn_clone.py                     | ○ Skipped | 0 s
wallet_txn_clone.py --mineblock         | ○ Skipped | 0 s
wallet_txn_doublespend.py               | ○ Skipped | 0 s
wallet_txn_doublespend.py --mineblock   | ○ Skipped | 0 s
wallet_watchonly.py                     | ○ Skipped | 0 s
wallet_watchonly.py --usecli            | ○ Skipped | 0 s
wallet_zapwallettxes.py                 | ○ Skipped | 0 s
interface_zmq.py                        | ✖ Failed  | 63 s

ALL                                     | ✖ Failed  | 325 s (accumulated) 
Runtime: 89 s

[17/373] Test Bitcoin RPC authentication...
...
----------------------------------------------------------------------
Ran 3 tests in 0.005s

OK
[19/373] cd /work/contrib/devtools/chainparams && /usr/bin/python3.7 ./test_make_chainparams.py
.....
----------------------------------------------------------------------
Ran 5 tests in 0.001s

OK
[95/373] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/script_tests.cpp.o
In file included from /usr/include/boost/test/unit_test.hpp:19,
                 from ../../src/test/script_tests.cpp:30:
../../src/test/script_tests.cpp: In member function ‘void script_tests::script_build::test_method()’:
../../src/test/script_tests.cpp:541:22: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
 BOOST_AUTO_TEST_CASE(script_build) {
                      ^~~~~~~~~~~~
[145/373] Running seeder test suite
PASSED: seeder test suite
[153/373] Running pow test suite
PASSED: pow test suite
[162/373] Running avalanche test suite
PASSED: avalanche test suite
[168/373] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[372/373] Running bitcoin test suite
PASSED: bitcoin test suite
FAILED: test/CMakeFiles/check-functional 
cd /work/abc-ci-builds/build-without-wallet/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/log && /usr/bin/cmake -E env /usr/bin/python3.7 ./functional/test_runner.py "--testsuitename=Bitcoin ABC functional tests" --junitoutput=/work/abc-ci-builds/build-without-wallet/test/junit/functional_tests.xml
ninja: build stopped: cannot make progress due to previous errors.
Build build-without-wallet failed with exit code 1

Each failure log is accessible here:
Bitcoin ABC functional tests: interface_zmq.py

deadalnix requested changes to this revision.Sep 3 2020, 18:06
deadalnix added a subscriber: deadalnix.

Check the test suite

This revision now requires changes to proceed.Sep 3 2020, 18:06
majcosta updated this revision to Diff 23249.Sep 3 2020, 19:06

rebase on top of D7344

majcosta edited the summary of this revision. (Show Details)Sep 3 2020, 19:07
majcosta added a parent revision: D7344: [backport#16404] qa: Test ZMQ notification after chain reorg.
majcosta added a child revision: D7345: [backport#17445] zmq: Fix due to invalid argument and multiple notifiers.Sep 3 2020, 19:16
Harbormaster completed remote builds in B12595: Diff 23249.Sep 3 2020, 19:41
deadalnix accepted this revision.Sep 3 2020, 21:29
deadalnix added inline comments.
test/functional/interface_zmq.py
19 ↗(On Diff #23249)

Amen.

I got tripped by this one a few times.

This revision is now accepted and ready to land.Sep 3 2020, 21:29
Closed by commit rABCe516d58d922e: [backport#16598] test: Remove confusing hash256 function in util (authored by fanquake <fanquake@gmail.com>, committed by majcosta). · Explain WhySep 3 2020, 21:39
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCe516d58d922e: [backport#16598] test: Remove confusing hash256 function in util.

Revision Contents
Changeset List

PathSize
test/
functional/
11 lines
test_framework/
9 lines

Diff 23266

View Options

test/functional/interface_zmq.py

Loading...
View Options

test/functional/test_framework/util.py

Loading...