Page MenuHomePhabricator

[backport#16404] qa: Refactor ZMQ test
ClosedPublic

Authored by majcosta on Sep 3 2020, 19:02.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCce6847916a52: [backport#16404] qa: Refactor ZMQ test
Summary

https://github.com/bitcoin/bitcoin/pull/16404/commits/aa2622a726bc0f02152d79c888a332694678a989

Partial backport of Core PR16404 and PR16740 (PR16404 on its own is broken and will not pass the tests otherwise, sorry)

notes:

* test looks to be wrong. socket.connect() is running before there is a node with the proper -zmqxx=xx CLI parameters set, so I moved it accordingly.

Test Plan
ninja
./test/functional/test_runner.py interface_zmq

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta requested review of this revision.Sep 3 2020, 19:03

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

added the entirety of PR16740

This revision is now accepted and ready to land.Sep 3 2020, 21:34