Page MenuHomePhabricator
Differential D7343

[backport#16404] qa: Refactor ZMQ test
ClosedPublic
Actions

Authored by majcosta on Sep 3 2020, 19:02.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCce6847916a52: [backport#16404] qa: Refactor ZMQ test
Summary

https://github.com/bitcoin/bitcoin/pull/16404/commits/aa2622a726bc0f02152d79c888a332694678a989

Partial backport of Core PR16404 and PR16740 (PR16404 on its own is broken and will not pass the tests otherwise, sorry)

notes:

* test looks to be wrong. socket.connect() is running before there is a node with the proper -zmqxx=xx CLI parameters set, so I moved it accordingly.

Test Plan
ninja
./test/functional/test_runner.py interface_zmq

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Sep 3 2020, 19:02
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 3 2020, 19:03
majcosta requested review of this revision.Sep 3 2020, 19:03
teamcity edited the summary of this revision. (Show Details)Sep 3 2020, 19:03

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta added a child revision: D7344: [backport#16404] qa: Test ZMQ notification after chain reorg.Sep 3 2020, 19:05
majcosta edited the summary of this revision. (Show Details)Sep 3 2020, 19:08
Harbormaster completed remote builds in B12593: Diff 23247.Sep 3 2020, 19:35
majcosta updated this revision to Diff 23261.Sep 3 2020, 21:14

added the entirety of PR16740

majcosta edited the summary of this revision. (Show Details)Sep 3 2020, 21:16
majcosta edited the summary of this revision. (Show Details)Sep 3 2020, 21:19
Harbormaster completed remote builds in B12603: Diff 23261.Sep 3 2020, 21:28
deadalnix accepted this revision.Sep 3 2020, 21:34
This revision is now accepted and ready to land.Sep 3 2020, 21:34
Closed by commit rABCce6847916a52: [backport#16404] qa: Refactor ZMQ test (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by majcosta). · Explain WhySep 3 2020, 21:37
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCce6847916a52: [backport#16404] qa: Refactor ZMQ test.

Revision Contents
Changeset List

PathSize
test/
functional/
75 lines

Diff 23264

View Options

test/functional/interface_zmq.py

Loading...