Differential D7345

[backport#17445] zmq: Fix due to invalid argument and multiple notifiers
ClosedPublic
Actions

Authored by majcosta on Sep 3 2020, 19:15.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC979e8272c7f9: [backport#17445] zmq: Fix due to invalid argument and multiple notifiers

Summary

zmq: Fix due to invalid argument and multiple notifiers (João Barbosa)

Pull request description:

ZMQ initialization is interrupted if any notifier fails, and in that case all notifiers are destroyed. The notifier shutdown assumes that the initialization had occurred. This is not valid when there are multiple notifiers and any except the last fails to initialize.

Can be tested by running test/functional/interface_zmq.py from this branch with bitcoind from master.

Closes #17185.

Depends on D7341

Backport of Core PR17445

Test Plan

ninja
./test/functional/test_runner.py interface_zmq

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Sep 3 2020, 19:15

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 3 2020, 19:15

majcosta requested review of this revision.Sep 3 2020, 19:15

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta edited the summary of this revision. (Show Details)Sep 3 2020, 19:16

majcosta added a parent revision: D7341: [backport#16598] test: Remove confusing hash256 function in util.

majcosta added a child revision: D7346: [backport#19507] Make ordering of zmq consumption irrelevant to functional test.Sep 3 2020, 19:21

Harbormaster completed remote builds in B12596: Diff 23250.Sep 3 2020, 19:48

deadalnix accepted this revision.Sep 3 2020, 21:30

This revision is now accepted and ready to land.Sep 3 2020, 21:30

Closed by commit rABC979e8272c7f9: [backport#17445] zmq: Fix due to invalid argument and multiple notifiers (authored by Wladimir J. van der Laan <laanwj@protonmail.com>, committed by majcosta). · Explain WhySep 3 2020, 21:40

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC979e8272c7f9: [backport#17445] zmq: Fix due to invalid argument and multiple notifiers.

Revision Contents
Changeset List

Path

Size

src/

zmq/

zmqpublishnotifier.cpp

5 lines

test/

functional/

interface_zmq.py

4 lines

Diff 23267

View Options

src/zmq/zmqpublishnotifier.cpp