Differential D7330

[backport#15426] [Doc] importmulti: add missing description of keypool option
ClosedPublic
Actions

Authored by majcosta on Sep 2 2020, 22:21.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABCe70d784e4bd3: [backport#15426] [Doc] importmulti: add missing description of keypool option

Summary

[Doc] importmulti: add missing description of keypool option (David A. Harding)

Pull request description:

Option was added in #14075 but not documented there.

CC: @achow101

https://github.com/bitcoin/bitcoin/pull/15426/commits/a607c9ae4c2730fca5ce340c400c95c87e498a7c

Depends on D7349

Backport of Core PR15426

Test Plan

ninja
./src/bitcoind -regtest
./src/bitcoin-cli -regtest help importmulti

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Sep 2 2020, 22:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 2 2020, 22:21

majcosta requested review of this revision.Sep 2 2020, 22:21

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12575: Diff 23218.Sep 2 2020, 22:27

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Snippet of first build failure:

[0m[1;30mwallet_hd.py                            | ○ Skipped | 0 s
[0m[1;30mwallet_import_rescan.py                 | ○ Skipped | 0 s
[0m[1;30mwallet_import_with_label.py             | ○ Skipped | 0 s
[0m[1;30mwallet_importmulti.py                   | ○ Skipped | 0 s
[0m[1;30mwallet_importprunedfunds.py             | ○ Skipped | 0 s
[0m[1;30mwallet_keypool.py                       | ○ Skipped | 0 s
[0m[1;30mwallet_keypool_topup.py                 | ○ Skipped | 0 s
[0m[1;30mwallet_labels.py                        | ○ Skipped | 0 s
[0m[1;30mwallet_listreceivedby.py                | ○ Skipped | 0 s
[0m[1;30mwallet_listsinceblock.py                | ○ Skipped | 0 s
[0m[1;30mwallet_listtransactions.py              | ○ Skipped | 0 s
[0m[1;30mwallet_multiwallet.py                   | ○ Skipped | 0 s
[0m[1;30mwallet_multiwallet.py --usecli          | ○ Skipped | 0 s
[0m[1;30mwallet_reorgsrestore.py                 | ○ Skipped | 0 s
[0m[1;30mwallet_resendwallettransactions.py      | ○ Skipped | 0 s
[0m[1;30mwallet_txn_clone.py                     | ○ Skipped | 0 s
[0m[1;30mwallet_txn_clone.py --mineblock         | ○ Skipped | 0 s
[0m[1;30mwallet_txn_doublespend.py               | ○ Skipped | 0 s
[0m[1;30mwallet_txn_doublespend.py --mineblock   | ○ Skipped | 0 s
[0m[1;30mwallet_watchonly.py                     | ○ Skipped | 0 s
[0m[1;30mwallet_watchonly.py --usecli            | ○ Skipped | 0 s
[0m[1;30mwallet_zapwallettxes.py                 | ○ Skipped | 0 s
[0m[0;31minterface_zmq.py                        | ✖ Failed  | 62 s
[0m[0;31m[1m
ALL                                     | ✖ Failed  | 379 s (accumulated) 
[0m[0mRuntime: 90 s

[19/373] Test Bitcoin RPC authentication...
...
----------------------------------------------------------------------
Ran 3 tests in 0.004s

OK
[20/373] cd /work/contrib/devtools/chainparams && /usr/bin/python3.7 ./test_make_chainparams.py
.....
----------------------------------------------------------------------
Ran 5 tests in 0.001s

OK
[95/373] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/script_tests.cpp.o
In file included from /usr/include/boost/test/unit_test.hpp:19,
                 from ../../src/test/script_tests.cpp:30:
../../src/test/script_tests.cpp: In member function ‘void script_tests::script_build::test_method()’:
../../src/test/script_tests.cpp:541:22: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
 BOOST_AUTO_TEST_CASE(script_build) {
                      ^~~~~~~~~~~~
[152/373] Running seeder test suite
PASSED: seeder test suite
[155/373] Running avalanche test suite
PASSED: avalanche test suite
[161/373] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[166/373] Running pow test suite
PASSED: pow test suite
[372/373] Running bitcoin test suite
PASSED: bitcoin test suite
FAILED: test/CMakeFiles/check-functional 
cd /work/abc-ci-builds/build-without-wallet/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/log && /usr/bin/cmake -E env /usr/bin/python3.7 ./functional/test_runner.py "--testsuitename=Bitcoin ABC functional tests" --junitoutput=/work/abc-ci-builds/build-without-wallet/test/junit/functional_tests.xml
ninja: build stopped: cannot make progress due to previous errors.
Build build-without-wallet failed with exit code 1

Each failure log is accessible here:
Bitcoin ABC functional tests: interface_zmq.py