HomePhabricator

[backport#17242] refactor: Remove unused cacheSigStore from…

Description

[backport#17242] refactor: Remove unused cacheSigStore from CheckInputsFromMempooAndCache

Summary:
0a433fc876d82df1005f175c1254fff62f0f36f8 [validation] Remove unused cacheSigStore from CheckInputsFromMempoolAndCache (John Newbery)

Pull request description:

CheckInputsFromMempoolAndCache() is only called in one place, and
cacheSigStore is set to true in that call site. Remove the argument
entirely.

Also improve commenting.

Backport of Core PR17242

Test Plan:

ninja all check check-functional

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D8753

Details

Provenance
fanquake <fanquake@gmail.com>Authored on Oct 25 2019, 11:57
majcostaCommitted on Dec 24 2020, 16:06
majcostaPushed on Dec 24 2020, 16:07
Reviewer
Restricted Project
Differential Revision
D8753: [backport#17242] refactor: Remove unused cacheSigStore from CheckInputsFromMempooAndCache
Parents
rABC272c12f83d8f: [backport#16852] gui: When BIP70 is disabled, get PaymentRequest merchant using…
Branches
Unknown
Tags
Unknown