Differential D8753

[backport#17242] refactor: Remove unused cacheSigStore from CheckInputsFromMempooAndCache
ClosedPublic
Actions

Authored by majcosta on Dec 24 2020, 04:49.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC9ca4736e58ae: [backport#17242] refactor: Remove unused cacheSigStore from…

Summary

0a433fc876d82df1005f175c1254fff62f0f36f8 [validation] Remove unused cacheSigStore from CheckInputsFromMempoolAndCache (John Newbery)

Pull request description:

CheckInputsFromMempoolAndCache() is only called in one place, and
cacheSigStore is set to true in that call site. Remove the argument
entirely.

Also improve commenting.

Backport of Core PR17242

Test Plan

ninja all check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Dec 24 2020, 04:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 24 2020, 04:50

majcosta requested review of this revision.Dec 24 2020, 04:50

teamcity edited the summary of this revision. (Show Details)Dec 24 2020, 04:50

Harbormaster completed remote builds in B14520: Diff 26553.Dec 24 2020, 05:04

PiRK accepted this revision.Dec 24 2020, 13:56

This revision is now accepted and ready to land.Dec 24 2020, 13:56

Closed by commit rABC9ca4736e58ae: [backport#17242] refactor: Remove unused cacheSigStore from… (authored by fanquake <fanquake@gmail.com>, committed by majcosta). · Explain WhyDec 24 2020, 16:07

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC9ca4736e58ae: [backport#17242] refactor: Remove unused cacheSigStore from….

Revision Contents
Changeset List

Path

Size

src/

validation.cpp

9 lines

Diff 26564

View Options

[backport#17242] refactor: Remove unused cacheSigStore from CheckInputsFromMempooAndCacheClosedPublicActions