HomePhabricator

Integrate the lint-tests.sh linter into arcanist

Authored by Fabien on Feb 8 2019, 16:39.

Description

Integrate the lint-tests.sh linter into arcanist

Summary:

  • Make the lint-tests.sh script take a single file at input for name mismatch checking
  • Add a new arcanist linter that runs lint-tests.sh and parse the output
  • Make the lint-tests.sh script return 0 to avoid arcanist dropping the linter due to failure

Depends on D2532

Test Plan:
Run arc lint, check there is no error.

Modify src/wallet/wallet_crypto_tests.cpp:
On the line containing BOOST_FIXTURE_TEST_SUITE, replace the test name:
wallet_crypto_tests by crypto_test
Run arc lint
Check that 2 errors are reported, on for name mismatch and one for
duplicated name.

Modify any cpp file directly located under src/
Run arc lint --trace
Check in the output that the file is not passed to the test linter.

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: teamcity, schancel

Differential Revision: https://reviews.bitcoinabc.org/D2533

Details

Committed
FabienFeb 10 2019, 14:40
Pushed
FabienFeb 10 2019, 14:40
Reviewer
Restricted Project
Differential Revision
D2533: Integrate the lint-tests.sh linter into arcanist
Parents
rABCf952a1b9bf84: Add a linter to enfore unit tests file name/boost name match and unicity
Branches
Unknown
Tags
Unknown