Page MenuHomePhabricator
Differential D2532

Add a linter to enfore unit tests file name/boost name match and unicity
ClosedPublic
Actions

Authored by Fabien on Feb 9 2019, 08:36.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGf952a1b9bf84: Add a linter to enfore unit tests file name/boost name match and unicity
rABCf952a1b9bf84: Add a linter to enfore unit tests file name/boost name match and unicity
Summary

This linter will warn if:

  • The BOOST_FIXTURE_TEST_SUITE name does not match the file name
  • The test name is not unique

Also add an entry in the dev notes.

Based on core PR12719 and PR12859

Test Plan

Should return nothing:

./test/lint/lint-tests.sh

Rename the BOOST_FIXTURE_TEST_SUITE name in
src/wallet/test/wallet_crypto_tests.cpp to crypto_tests.

./test/lint/lint-tests.sh

Check the mismatch and the duplicata are detected

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Feb 9 2019, 08:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 9 2019, 08:36
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Feb 9 2019, 08:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien added a child revision: D2533: Integrate the lint-tests.sh linter into arcanist.Feb 9 2019, 08:51
teamcity added a comment.Feb 9 2019, 08:52

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4940: Diff 7273.Feb 9 2019, 08:52
deadalnix accepted this revision.Feb 9 2019, 16:29
This revision is now accepted and ready to land.Feb 9 2019, 16:29
Closed by commit rABCf952a1b9bf84: Add a linter to enfore unit tests file name/boost name match and unicity (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by Fabien). · Explain WhyFeb 10 2019, 09:55
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rSTAGINGf952a1b9bf84: Add a linter to enfore unit tests file name/boost name match and unicity.Sep 18 2019, 22:21

Revision Contents
Changeset List

PathSize
doc/
6 lines
test/
lint/
41 lines

Diff 7286

View Options

doc/developer-notes.md

Loading...
View Options

test/lint/lint-tests.sh

Loading...