HomePhabricator

Move key and script filling and signing from CWallet::FillPSBT to…

Description

Move key and script filling and signing from CWallet::FillPSBT to ScriptPubKeyMan::FillPSBT

Summary:
Instead of fetching a SigningProvider from ScriptPubKeyMan in order
to fill and sign the keys and scripts for a PSBT, just pass that
PSBT to a new FillPSBT function that does all that for us.

Backport of Core PR18115 part [6/9] : https://github.com/bitcoin/bitcoin/pull/18115/commits/82a30fade70a2a95c2bbeac4aa06dafda600479d

Depends on D8097

Test Plan:

ninja all check-all

Reviewers: #bitcoin_abc, majcosta

Reviewed By: #bitcoin_abc, majcosta

Differential Revision: https://reviews.bitcoinabc.org/D8101

Details

Provenance
Andrew Chow <achow101-github@achow101.com>Authored on Feb 11 2020, 00:50
deadalnixCommitted on Oct 25 2020, 15:14
deadalnixPushed on Oct 25 2020, 15:14
Reviewer
Restricted Project
Differential Revision
D8101: Move key and script filling and signing from CWallet::FillPSBT to ScriptPubKeyMan::FillPSBT
Parents
rABCf0ce8173081f: Move FillPSBT to be a member of CWallet
Branches
Unknown
Tags
Unknown