Page MenuHomePhabricator

Move FillPSBT to be a member of CWallet
ClosedPublic

Authored by deadalnix on Oct 24 2020, 17:18.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCf0ce8173081f: Move FillPSBT to be a member of CWallet
Summary
Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

PiRK requested changes to this revision.Oct 24 2020, 18:47
PiRK added a subscriber: PiRK.
PiRK added inline comments.
src/wallet/wallet.h
1122 ↗(On Diff #25049)

Wouldn't it be better to do the change for the default value of bip32derivs to true in a separate diff? There seem to be some additional changes related to this change (tests, documentation), when I look at PR17264

This revision now requires changes to proceed.Oct 24 2020, 18:47
deadalnix added inline comments.
src/wallet/wallet.h
1122 ↗(On Diff #25049)

Let's add it to the queue, we can move forward here anyways.

This revision is now accepted and ready to land.Oct 25 2020, 04:46