Paths

Table of Contentst

Differential D8097

Move FillPSBT to be a member of CWallet
ClosedPublic
Actions

Authored by deadalnix on Oct 24 2020, 17:18.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCf0ce8173081f: Move FillPSBT to be a member of CWallet

Summary

Backport of Core PR18115 part [5/9] : https://github.com/bitcoin/bitcoin/pull/18115/commits/3d70dd99f9f74eef70b19ff6f6f850adc0d5ef8f

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr18115-5

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13649
Build 27324: Build Diff	build-debug · build-clang-tidy · build-without-wallet · build-diff · build-clang · lint-circular-dependencies
Build 27323: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 24 2020, 17:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 24 2020, 17:18

deadalnix requested review of this revision.Oct 24 2020, 17:18

teamcity edited the summary of this revision. (Show Details)Oct 24 2020, 17:18

Harbormaster completed remote builds in B13649: Diff 25049.Oct 24 2020, 17:27

PiRK requested changes to this revision.Oct 24 2020, 18:47

PiRK added a subscriber: PiRK.

PiRK added inline comments.

src/wallet/wallet.h
1122	Wouldn't it be better to do the change for the default value of `bip32derivs` to `true` in a separate diff? There seem to be some additional changes related to this change (tests, documentation), when I look at PR17264

This revision now requires changes to proceed.Oct 24 2020, 18:47

deadalnix added a child revision: D8101: Move key and script filling and signing from CWallet::FillPSBT to ScriptPubKeyMan::FillPSBT.Oct 24 2020, 21:51

deadalnix requested review of this revision.Oct 24 2020, 22:25

deadalnix added inline comments.

src/wallet/wallet.h
1122	Let's add it to the queue, we can move forward here anyways.

rebase on top of PR17264

Harbormaster completed remote builds in B13657: Diff 25065.Oct 25 2020, 00:46

PiRK accepted this revision.Oct 25 2020, 04:46

This revision is now accepted and ready to land.Oct 25 2020, 04:46

Closed by commit rABCf0ce8173081f: Move FillPSBT to be a member of CWallet (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain WhyOct 25 2020, 15:09

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCf0ce8173081f: Move FillPSBT to be a member of CWallet.

PiRK mentioned this in D8620: Fix doxygen errors.Dec 7 2020, 16:12

PiRK mentioned this in rABC65689e2656e3: Fix doxygen errors.Dec 7 2020, 17:09

Revision Contents
Changeset List

Path

Size

src/

interfaces/

2 lines

7 lines

qt/

sendcoinsdialog.cpp

1 line

wallet/

1 line

8 lines

test/

psbt_wallet_tests.cpp

3 lines

21 lines

76 lines

Diff 25049

src/interfaces/wallet.h

Loading...

src/interfaces/wallet.cpp

Loading...

src/qt/sendcoinsdialog.cpp

Loading...

src/wallet/CMakeLists.txt

Loading...

src/wallet/psbtwallet.h

Loading...

src/wallet/psbtwallet.cpp

Loading...

src/wallet/rpcwallet.cpp

Loading...

src/wallet/test/psbt_wallet_tests.cpp

Loading...

src/wallet/wallet.h

Loading...

src/wallet/wallet.cpp

Loading...