Differential D8101

Move key and script filling and signing from CWallet::FillPSBT to ScriptPubKeyMan::FillPSBT
ClosedPublic
Actions

Authored by deadalnix on Oct 24 2020, 21:51.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABCbee3cb09b38b: Move key and script filling and signing from CWallet::FillPSBT to…

Summary

Instead of fetching a SigningProvider from ScriptPubKeyMan in order
to fill and sign the keys and scripts for a PSBT, just pass that
PSBT to a new FillPSBT function that does all that for us.

Backport of Core PR18115 part [6/9] : https://github.com/bitcoin/bitcoin/pull/18115/commits/82a30fade70a2a95c2bbeac4aa06dafda600479d

Depends on D8097

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Oct 24 2020, 21:51

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 24 2020, 21:51

deadalnix requested review of this revision.Oct 24 2020, 21:51

teamcity edited the summary of this revision. (Show Details)Oct 24 2020, 21:51

Harbormaster completed remote builds in B13653: Diff 25057.Oct 24 2020, 22:01

deadalnix added a child revision: D8102: Move direct calls to MessageSign into new SignMessage functions in CWallet and ScriptPubKeyMan.Oct 24 2020, 22:03

majcosta accepted this revision.Oct 25 2020, 00:12

This revision is now accepted and ready to land.Oct 25 2020, 00:12

Closed by commit rABCbee3cb09b38b: Move key and script filling and signing from CWallet::FillPSBT to… (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain WhyOct 25 2020, 15:15

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCbee3cb09b38b: Move key and script filling and signing from CWallet::FillPSBT to….

Revision Contents
Changeset List

Path

Size

src/

wallet/

scriptpubkeyman.h

16 lines

scriptpubkeyman.cpp

43 lines

wallet.cpp

62 lines

Diff 25078

View Options

src/wallet/scriptpubkeyman.h

View Options

src/wallet/scriptpubkeyman.cpp

View Options

Move key and script filling and signing from CWallet::FillPSBT to ScriptPubKeyMan::FillPSBTClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 25078

src/wallet/scriptpubkeyman.h

src/wallet/scriptpubkeyman.cpp

src/wallet/wallet.cpp

Move key and script filling and signing from CWallet::FillPSBT to ScriptPubKeyMan::FillPSBT
ClosedPublic
Actions

Revision Contents
Changeset List