HomePhabricator

Ignore unknown config file options, warn instead of error

Authored by Pieter Wuille <pieter.wuille@gmail.com> on Jul 30 2018, 07:14.

Description

Ignore unknown config file options, warn instead of error

Summary:

As reported by @satwo on IRC a few days ago, the current mechanism of
treating unknown config file options as errors is problematic for
options like -rpcclienttimeout which aren't defined for bitcoind.

A full solution would be to either make all binaries be aware of each
other's options, or to permit config file options that only apply to
specific binaries (bitcoind, bitcoin-qt, bitcoin-cli). Both of these
seem too invasive to introduce for 0.17.

As a compromise, this PR makes it ignores those options, but still warn
about it in the log file.

Backport of core PR13799.

Depends on D5553 (it is buggy otherwise).

Test Plan:

ninja all check
./test/functional/test_runner.py feature_includeconf

Reviewers: #bitcoin_abc, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D5554

Details

Committed
FabienThu, Mar 26, 10:21
Pushed
FabienThu, Mar 26, 10:21
Reviewer
Restricted Project
Differential Revision
D5554: Ignore unknown config file options, warn instead of error
Parents
rABCd0af7ae7dfb9: util: Log early messages
Branches
Unknown
Tags
Unknown