util: Log early messages
ClosedPublic
Actions

Authored by Fabien on Mar 24 2020, 12:52.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGINGd0af7ae7dfb9: util: Log early messages
rABCd0af7ae7dfb9: util: Log early messages

Summary

Early log messages are dropped on the floor and they'd never make it to
the console or debug log. This can be tested by running the test
included in this pull request without re-compiling the bitcoind.

Fix that by buffering early messages and flushing them as soon as all
logging options have been initialized and logging has been started.

Backport of core PR16112.

Test Plan

ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Mar 24 2020, 12:52

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 24 2020, 12:52

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9949: Diff 17140.Mar 24 2020, 13:05

Fabien added a child revision: D5554: Ignore unknown config file options, warn instead of error.Mar 24 2020, 13:12

deadalnix requested changes to this revision.Mar 24 2020, 13:47

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

src/logging.h
65 ↗	(On Diff #17140)	Why not an actual annotation rather than a comment?

This revision now requires changes to proceed.Mar 24 2020, 13:47

Fabien requested review of this revision.Mar 24 2020, 13:56

Fabien added inline comments.

src/logging.h
65 ↗	(On Diff #17140)	My understanding is that by not using the sync.h wrappers, the lock annotations (`EXCLUSIVE_LOCK_FUNCTION()`, `UNLOCK_FUNCTION()`, ...) are missing and `GUARDED_BY()` cannot be evaluated.