Page MenuHomePhabricator

tests: remove unused includes in tests
ClosedPublic

Authored by Fabien on Tue, Mar 24, 15:39.

Details

Summary

Backport of core PR16278.

Depends on D5556.

Test Plan
ninja all check

Run the Gitian builds.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Tue, Mar 24, 15:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Mar 24, 15:39
teamcity edited the summary of this revision. (Show Details)Tue, Mar 24, 15:39

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien planned changes to this revision.Tue, Mar 24, 15:39

Pending gitian builds.

Fabien requested review of this revision.Tue, Mar 24, 16:07

All passed

jasonbcox requested changes to this revision.Wed, Mar 25, 00:47
jasonbcox added a subscriber: jasonbcox.

Appears to be missing changes in pow_tests.cpp and raii_event_tests.cpp

src/test/txvalidation_tests.cpp
9 ↗(On Diff #17145)

Is txmempool.h still needed here?

This revision now requires changes to proceed.Wed, Mar 25, 00:47
Fabien added inline comments.Wed, Mar 25, 08:17
src/test/txvalidation_tests.cpp
9 ↗(On Diff #17145)

Yes, validation.h has a forward declaration for CTXMemPool but it needs the definition at the source level. I don't know what indirect inclusion core has to make it build (Note: current core master has it included in validation.h but from a later commit).

Fabien updated this revision to Diff 17159.Wed, Mar 25, 08:21

Add missing changes.

jasonbcox accepted this revision.Wed, Mar 25, 16:01
This revision is now accepted and ready to land.Wed, Mar 25, 16:01
This revision was automatically updated to reflect the committed changes.