Paths

Table of Contentst

Differential D5558

tests: remove unused includes in tests
ClosedPublic
Actions

Authored by Fabien on Mar 24 2020, 15:39.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING6a4262702c89: tests: remove unused includes in tests
rABC6a4262702c89: tests: remove unused includes in tests

Summary

Backport of core PR16278.

Depends on D5556.

Test Plan

ninja all check

Run the Gitian builds.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR16278

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9954
Build 17762: Default Diff Build & Tests
Build 17761: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 24 2020, 15:39

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 24 2020, 15:39

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Pending gitian builds.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (linux) started.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (osx) started.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (win) started.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (osx) passed.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9954: Diff 17145.Mar 24 2020, 15:49

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (linux) passed.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (win) passed.

All passed

Appears to be missing changes in pow_tests.cpp and raii_event_tests.cpp

src/test/txvalidation_tests.cpp
9	Is txmempool.h still needed here?

This revision now requires changes to proceed.Mar 25 2020, 00:47

Fabien added inline comments.Mar 25 2020, 08:17

src/test/txvalidation_tests.cpp
9	Yes, `validation.h` has a forward declaration for `CTXMemPool` but it needs the definition at the source level. I don't know what indirect inclusion core has to make it build (Note: current core master has it included in `validation.h` but from a later commit).

Add missing changes.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9961: Diff 17159.Mar 25 2020, 08:34

jasonbcox accepted this revision.Mar 25 2020, 16:01

This revision is now accepted and ready to land.Mar 25 2020, 16:01

Closed by commit rABC6a4262702c89: tests: remove unused includes in tests (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by Fabien). · Explain WhyMar 26 2020, 10:28

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC6a4262702c89: tests: remove unused includes in tests.

Fabien added a commit: rSTAGING6a4262702c89: tests: remove unused includes in tests.Apr 7 2020, 23:28

Revision Contents
Changeset List

Path

Size

src/

qt/

test/

addressbooktests.cpp

1 line

1 line

rpcnestedtests.h

3 lines

rpcnestedtests.cpp

1 line

1 line

test/

allocator_tests.cpp

1 line

arith_uint256_tests.cpp

1 line

bip32_tests.cpp

1 line

blockencodings_tests.cpp

1 line

checkqueue_tests.cpp

1 line

dbwrapper_tests.cpp

1 line

denialofservice_tests.cpp

1 line

flatfile_tests.cpp

1 line

2 lines

fuzz/

deserialize.cpp

4 lines

1 line

script_flags.cpp

1 line

2 lines

1 line

mempool_tests.cpp

2 lines

miner_tests.cpp

2 lines

2 lines

policyestimator_tests.cpp

1 line

1 line

script_standard_tests.cpp

1 line

script_tests.cpp

1 line

1 line

setup_common.cpp

7 lines

sigopcount_tests.cpp

1 line

streams_tests.cpp

2 lines

txvalidation_tests.cpp

4 lines

txvalidationcache_tests.cpp

4 lines

uint256_tests.cpp

3 lines

3 lines

validation_block_tests.cpp

2 lines

wallet/

test/

1 line

psbt_wallet_tests.cpp

3 lines

wallet_test_fixture.cpp

2 lines

wallet_tests.cpp

2 lines

Diff 17145

src/qt/test/addressbooktests.cpp

Loading...

src/qt/test/apptests.cpp

Loading...

src/qt/test/rpcnestedtests.h

Loading...

src/qt/test/rpcnestedtests.cpp

Loading...

src/qt/test/test_main.cpp

Loading...

src/test/allocator_tests.cpp

Loading...

src/test/arith_uint256_tests.cpp

Loading...

src/test/bip32_tests.cpp

Loading...

src/test/blockencodings_tests.cpp

Loading...

src/test/checkqueue_tests.cpp

Loading...

src/test/dbwrapper_tests.cpp

Loading...

src/test/denialofservice_tests.cpp

Loading...

src/test/flatfile_tests.cpp

Loading...

src/test/fs_tests.cpp

Loading...

src/test/fuzz/deserialize.cpp

Loading...

src/test/fuzz/fuzz.h

Loading...

src/test/fuzz/script_flags.cpp

Loading...

src/test/hash_tests.cpp

Loading...

src/test/key_tests.cpp

Loading...

src/test/mempool_tests.cpp

Loading...

src/test/miner_tests.cpp

Loading...

src/test/net_tests.cpp

Loading...

src/test/policyestimator_tests.cpp

Loading...

src/test/rpc_tests.cpp

Loading...

src/test/script_standard_tests.cpp

Loading...

src/test/script_tests.cpp

Loading...

src/test/scriptnum10.h

Loading...

src/test/setup_common.cpp

Loading...

src/test/sigopcount_tests.cpp

Loading...

src/test/streams_tests.cpp

Loading...

src/test/txvalidation_tests.cpp

Loading...

src/test/txvalidationcache_tests.cpp

Loading...

src/test/uint256_tests.cpp

Loading...

src/test/util_tests.cpp

Loading...

src/test/validation_block_tests.cpp

Loading...

src/wallet/test/init_tests.cpp

Loading...

src/wallet/test/psbt_wallet_tests.cpp

Loading...

src/wallet/test/wallet_test_fixture.cpp

Loading...

src/wallet/test/wallet_tests.cpp

Loading...