Page MenuHomePhabricator

tests: remove unused includes in tests
ClosedPublic

Authored by Fabien on Mar 24 2020, 15:39.

Details

Summary

Backport of core PR16278.

Depends on D5556.

Test Plan
ninja all check

Run the Gitian builds.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR16278
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9954
Build 17762: Default Diff Build & Tests
Build 17761: arc lint + arc unit

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien planned changes to this revision.Mar 24 2020, 15:39

Pending gitian builds.

Fabien requested review of this revision.Mar 24 2020, 16:07

All passed

jasonbcox requested changes to this revision.Mar 25 2020, 00:47
jasonbcox added a subscriber: jasonbcox.

Appears to be missing changes in pow_tests.cpp and raii_event_tests.cpp

src/test/txvalidation_tests.cpp
9

Is txmempool.h still needed here?

This revision now requires changes to proceed.Mar 25 2020, 00:47
src/test/txvalidation_tests.cpp
9

Yes, validation.h has a forward declaration for CTXMemPool but it needs the definition at the source level. I don't know what indirect inclusion core has to make it build (Note: current core master has it included in validation.h but from a later commit).

This revision is now accepted and ready to land.Mar 25 2020, 16:01