Page MenuHomePhabricator

Ignore unknown config file options, warn instead of error
ClosedPublic

Authored by Fabien on Tue, Mar 24, 13:12.

Details

Summary
As reported by @satwo on IRC a few days ago, the current mechanism of
treating unknown config file options as errors is problematic for
options like -rpcclienttimeout which aren't defined for bitcoind.

A full solution would be to either make all binaries be aware of each
other's options, or to permit config file options that only apply to
specific binaries (bitcoind, bitcoin-qt, bitcoin-cli). Both of these
seem too invasive to introduce for 0.17.

As a compromise, this PR makes it ignores those options, but still warn
about it in the log file.

Backport of core PR13799.

Depends on D5553 (it is buggy otherwise).

Test Plan
ninja all check
./test/functional/test_runner.py feature_includeconf

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Tue, Mar 24, 13:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Mar 24, 13:12
teamcity edited the summary of this revision. (Show Details)Tue, Mar 24, 13:12

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

jasonbcox accepted this revision.Wed, Mar 25, 23:15
This revision is now accepted and ready to land.Wed, Mar 25, 23:15