Page MenuHomePhabricator

qt: test: Create at most one testing setup
ClosedPublic

Authored by Fabien on Tue, Mar 24, 15:01.

Details

Summary
It is assumed that ideally only one BasicTestingSetup exists at any
point in time for each process (due to use of globals).

This assumption is violated in the GUI tests, as a testing setup is
created as the first step of the main function and then (sometimes)
another one for the following test cases.

So, the gui tests create two testing setups:

    BasicTestingSetup in main (added in fa4a04a)
    a testing setup for individual test cases

Avoid that by destructing the testing setup in main after creation and
then move the explicit ECC_Stop to the only places where it is needed
(before and after apptests).

Backport of core PR16294.

Depends on D5556.

Test Plan
ninja check-bitcoin-qt

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Tue, Mar 24, 15:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Mar 24, 15:01
teamcity edited the summary of this revision. (Show Details)Tue, Mar 24, 15:01

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix accepted this revision.Wed, Mar 25, 23:49
This revision is now accepted and ready to land.Wed, Mar 25, 23:49
This revision was automatically updated to reflect the committed changes.