HomePhabricator

ClearArg also clears multi-args, add unit tests for args clearing

Description

ClearArg also clears multi-args, add unit tests for args clearing

Summary:
ClearArg() did not clear the multi arg map, which could lead to the
situation where GetArg("arg") returned its default value while
GetArgs("arg") returned a non empty vector.
Add unit tests for the ClearArg() method.

Test Plan:

make check

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: teamcity, schancel

Differential Revision: https://reviews.bitcoinabc.org/D2290

Details

Provenance
FabienAuthored on Jan 11 2019, 12:03
jasonbcoxPushed on Jan 11 2019, 18:58
Reviewer
Restricted Project
Differential Revision
D2290: ClearArg also clears multi-args, add unit tests for args clearing
Parents
rSTAGING53a20dab4d07: Fix links in doc/release-process.md
Branches
Unknown
Tags
Unknown