ClearArg also clears multi-args, add unit tests for args clearing
ClosedPublic
Actions

Authored by Fabien on Jan 11 2019, 12:04.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING11ac63c5f122: ClearArg also clears multi-args, add unit tests for args clearing
rABC11ac63c5f122: ClearArg also clears multi-args, add unit tests for args clearing

Summary

ClearArg() did not clear the multi arg map, which could lead to the
situation where GetArg("arg") returned its default value while
GetArgs("arg") returned a non empty vector.
Add unit tests for the ClearArg() method.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 11 2019, 12:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 11 2019, 12:04

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien retitled this revision from ClearArg also clears multi-args, add unit tests args setting/clearing to ClearArg also clears multi-args, add unit tests for args clearing.Jan 11 2019, 12:07

Fabien added a child revision: D2291: Add unit tests for the (Soft|Force)Set(Multi)?Arg methods.Jan 11 2019, 12:11

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4479: Diff 6601.Jan 11 2019, 12:14

Fabien mentioned this in D2275: Fix user agent sanitizer.Jan 11 2019, 14:59

Fabien added a child revision: D2275: Fix user agent sanitizer.Jan 11 2019, 14:59

deadalnix accepted this revision.Jan 11 2019, 15:43

This revision is now accepted and ready to land.Jan 11 2019, 15:43

Closed by commit rABC11ac63c5f122: ClearArg also clears multi-args, add unit tests for args clearing (authored by Fabien). · Explain WhyJan 11 2019, 17:30

This revision was automatically updated to reflect the committed changes.