Page MenuHomePhabricator

ClearArg also clears multi-args, add unit tests for args clearing
ClosedPublic

Authored by Fabien on Jan 11 2019, 12:04.

Details

Summary

ClearArg() did not clear the multi arg map, which could lead to the
situation where GetArg("arg") returned its default value while
GetArgs("arg") returned a non empty vector.
Add unit tests for the ClearArg() method.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Jan 11 2019, 12:04
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 11 2019, 12:04
Herald added a subscriber: schancel. · View Herald Transcript
Fabien retitled this revision from ClearArg also clears multi-args, add unit tests args setting/clearing to ClearArg also clears multi-args, add unit tests for args clearing.Jan 11 2019, 12:07
deadalnix accepted this revision.Jan 11 2019, 15:43
This revision is now accepted and ready to land.Jan 11 2019, 15:43
This revision was automatically updated to reflect the committed changes.