HomePhabricator

Merge #13022: [qa] Attach node index to test_node AssertionError and print…

Description

Merge #13022: [qa] Attach node index to test_node AssertionError and print messages

Summary:
80a5e59 [qa] Attach node index to test_node AssertionError and print messages (James O'Beirne)

Pull request description:

In the midst of fighting with https://github.com/bitcoin/bitcoin/pull/12873 it became apparent that there're a number of assertions and print statements which are emitted by test nodes but don't identify the node in question. This change makes debugging a bit easier by adding identifying information to non-logger test_node-related error messages.

Tree-SHA512: 7cc86f2c81f4b3fdba15ec9a2d21a84c4b083629e845e82288087c3affbbdc5c68e74067621856cc97fe84fbc8cb4f5ca4977a51ef381e5d74515df8eb001239

Backport of Core PR13022
https://github.com/bitcoin/bitcoin/pull/13022/files

Depends on D3914

Test Plan: test_runner.py

Reviewers: #bitcoin_abc, deadalnix, Fabien

Reviewed By: #bitcoin_abc, deadalnix, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D3915

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on Sep 11 2019, 17:24
jasonbcoxCommitted on Sep 17 2019, 22:41
nakihitoPushed on Sep 17 2019, 23:03
Reviewer
Restricted Project
Differential Revision
D3915: Merge #13022: [qa] Attach node index to test_node AssertionError and print messages
Parents
rSTAGINGba6478e676bc: Merge #15239: scripts and tools: Move non-linux build source tarballs to…
Branches
Unknown
Tags
Unknown