Paths

Table of Contentst

Differential D3914

Merge #12853: qa: Match full plain text by default
ClosedPublic
Actions

Authored by jasonbcox on Aug 19 2019, 22:24.

Tags

None

Subscribers

Details

Reviewers

deadalnix
Fabien
nakihito

Group Reviewers

Restricted Project

Commits

rSTAGINGa858653e5efc: Merge #12853: qa: Match full plain text by default
rABCa858653e5efc: Merge #12853: qa: Match full plain text by default

Summary

faace13868 qa: Match full plain text by default (MarcoFalke)

Pull request description:

Instead of escaping all full plain text error strings, just compare their strings by default.

Tree-SHA512: 42e28f55105eb947ac6af6ce4056f0ec0f701d85f1c2a38b35ab777bbdf2296bdb79639c345621b8adc03a98b28c7630ded9a67b8b04a48e2c3a49d598ecdcd7

Backport of Core PR12853
https://github.com/bitcoin/bitcoin/pull/12853/files

Test Plan

test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.Aug 19 2019, 22:24

Herald added a reviewer: deadalnix. · View Herald TranscriptAug 19 2019, 22:24

jasonbcox planned changes to this revision.Aug 19 2019, 22:24

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7196: Diff 10875.Aug 19 2019, 22:36

jasonbcox requested review of this revision.Aug 19 2019, 22:38

jasonbcox edited the summary of this revision. (Show Details)Aug 20 2019, 01:02

jasonbcox added a child revision: D3915: Merge #13022: [qa] Attach node index to test_node AssertionError and print messages.

Fabien requested changes to this revision.Aug 20 2019, 06:46

Fabien added a subscriber: Fabien.

Fabien added inline comments.

test/functional/test_framework/test_node.py
10 ↗	(On Diff #10875)	Nit: `enum` is lexically before `errno`
test/functional/wallet_multiwallet.py
95 ↗	(On Diff #10875)	Why did you remove the leading 'r' ? AFAIK the `\.` is not a valid escape sequence (regex-only), so I think it should still be required ?
127 ↗	(On Diff #10875)	Dito with the `\S` here.

This revision now requires changes to proceed.Aug 20 2019, 06:46

Rebase + fix according to feedback

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7351: Diff 11139.Sep 6 2019, 17:09

Fabien requested changes to this revision.Sep 9 2019, 06:27

Fabien added inline comments.

test/functional/test_framework/test_node.py
10 ↗	(On Diff #11139)	You missed this one :)

This revision now requires changes to proceed.Sep 9 2019, 06:27

Fixed import order

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7367: Diff 11166.Sep 9 2019, 17:51

Fabien accepted this revision.Sep 10 2019, 06:19

This revision is now accepted and ready to land.Sep 10 2019, 06:19

nakihito accepted this revision.Sep 10 2019, 20:26

Closed by commit rABCa858653e5efc: Merge #12853: qa: Match full plain text by default (authored by MarcoFalke <falke.marco@gmail.com>, committed by jasonbcox). · Explain WhySep 10 2019, 20:55

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABCa858653e5efc: Merge #12853: qa: Match full plain text by default.

jasonbcox added a commit: rSTAGINGa858653e5efc: Merge #12853: qa: Match full plain text by default.Sep 19 2019, 02:13

Revision Contents
Changeset List

Path

Size

test/

functional/

4 lines

feature_blocksdir.py

5 lines

feature_config_args.py

7 lines

feature_logging.py

5 lines

feature_uacomment.py

5 lines

test_framework/

17 lines

wallet_multiwallet.py

12 lines

Diff 11183

test/functional/abc-cmdline.py

Loading...

test/functional/feature_blocksdir.py

Loading...

test/functional/feature_config_args.py

Loading...

test/functional/feature_logging.py

Loading...

test/functional/feature_uacomment.py

Loading...

test/functional/test_framework/test_node.py

Loading...

test/functional/wallet_multiwallet.py

Loading...