Page MenuHomePhabricator

Merge #12853: qa: Match full plain text by default
ClosedPublic

Authored by jasonbcox on Mon, Aug 19, 22:24.

Details

Summary

faace13868 qa: Match full plain text by default (MarcoFalke)

Pull request description:

Instead of escaping all full plain text error strings, just compare their strings by default.

Tree-SHA512: 42e28f55105eb947ac6af6ce4056f0ec0f701d85f1c2a38b35ab777bbdf2296bdb79639c345621b8adc03a98b28c7630ded9a67b8b04a48e2c3a49d598ecdcd7

Backport of Core PR12853
https://github.com/bitcoin/bitcoin/pull/12853/files

Test Plan

test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Mon, Aug 19, 22:24
jasonbcox planned changes to this revision.Mon, Aug 19, 22:24
jasonbcox requested review of this revision.Mon, Aug 19, 22:38
Fabien requested changes to this revision.Tue, Aug 20, 06:46
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/test_framework/test_node.py
10 ↗(On Diff #10875)

Nit: enum is lexically before errno

test/functional/wallet_multiwallet.py
95 ↗(On Diff #10875)

Why did you remove the leading 'r' ? AFAIK the \. is not a valid escape sequence (regex-only), so I think it should still be required ?

127 ↗(On Diff #10875)

Dito with the \S here.

This revision now requires changes to proceed.Tue, Aug 20, 06:46
jasonbcox updated this revision to Diff 11139.Fri, Sep 6, 16:54

Rebase + fix according to feedback

Fabien requested changes to this revision.Mon, Sep 9, 06:27
Fabien added inline comments.
test/functional/test_framework/test_node.py
10 ↗(On Diff #11139)

You missed this one :)

This revision now requires changes to proceed.Mon, Sep 9, 06:27
jasonbcox updated this revision to Diff 11166.Mon, Sep 9, 17:39

Fixed import order

Fabien accepted this revision.Tue, Sep 10, 06:19
This revision is now accepted and ready to land.Tue, Sep 10, 06:19
nakihito accepted this revision.Tue, Sep 10, 20:26