HomePhabricator

Refactor signature encoding checks to separates checks of the SigHashType and…

Description

Refactor signature encoding checks to separates checks of the SigHashType and other checks

Summary:
This is done via slicing the sig to remove the SigHashType. Hopefully, the next step is to expose an API to check signature without the SigHashType which will allow to reduce the test time dramatically.

Depends on D1577

Test Plan:

make check

Reviewers: #bitcoin_abc, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Subscribers: teamcity

Differential Revision: https://reviews.bitcoinabc.org/D1578

Details

Provenance
deadalnixAuthored on Jul 18 2018, 00:06
jasonbcoxPushed on Jul 23 2018, 23:33
Reviewer
Restricted Project
Differential Revision
D1578: Refactor signature encoding checks to separates checks of the SigHashType and other checks
Parents
rSTAGING49c721931424: Ignore sighash when checking for DER encoding.
Branches
Unknown
Tags
Unknown