Page MenuHomePhabricator

Refactor signature encoding checks to separates checks of the SigHashType and other checks
ClosedPublic

Authored by deadalnix on Jul 18 2018, 01:05.

Details

Summary

This is done via slicing the sig to remove the SigHashType. Hopefully, the next step is to expose an API to check signature without the SigHashType which will allow to reduce the test time dramatically.

Depends on D1577

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Jul 18 2018, 01:05
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 18 2018, 01:05
deadalnix updated this revision to Diff 4345.Jul 18 2018, 11:59

Rename the funcion to CheckTransactionSignatureEncoding and add a doc comment.

deadalnix updated this revision to Diff 4346.Jul 18 2018, 13:37

Improve comments.

deadalnix updated this revision to Diff 4347.Jul 18 2018, 13:40

Rename the function checking the signature itself into CheckRawSignatureEncoding

deadalnix updated this revision to Diff 4349.Jul 18 2018, 14:59

Various nits

jasonbcox accepted this revision.Jul 23 2018, 14:52
This revision is now accepted and ready to land.Jul 23 2018, 14:52
This revision was automatically updated to reflect the committed changes.