Page MenuHomePhabricator

Refactor signature encoding checks to separates checks of the SigHashType and other checks

Authored by deadalnix on Jul 18 2018, 01:05.



This is done via slicing the sig to remove the SigHashType. Hopefully, the next step is to expose an API to check signature without the SigHashType which will allow to reduce the test time dramatically.

Depends on D1577

Test Plan
make check

Diff Detail

rABC Bitcoin ABC
Lint Not Applicable
Tests Not Applicable

Event Timeline

Rename the funcion to CheckTransactionSignatureEncoding and add a doc comment.

Rename the function checking the signature itself into CheckRawSignatureEncoding

This revision is now accepted and ready to land.Jul 23 2018, 14:52
This revision was automatically updated to reflect the committed changes.