Differential D1580

Make sigencoding_tests significantly faster by not checking the full sigashtype/flags combinatorial
ClosedPublic
Actions

Authored by deadalnix on Jul 18 2018, 16:06.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGab054f8c3f56: Make sigencoding_tests significantly faster by not checking the full…
rABCab054f8c3f56: Make sigencoding_tests significantly faster by not checking the full…

Summary

This required to expose checking of the signature without a hash type.

Depends on D1579

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Jul 18 2018, 16:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 18 2018, 16:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2900: Diff 4350.Jul 18 2018, 16:46

jasonbcox accepted this revision.Jul 23 2018, 15:37

This revision is now accepted and ready to land.Jul 23 2018, 15:37

Closed by commit rABCab054f8c3f56: Make sigencoding_tests significantly faster by not checking the full… (authored by deadalnix). · Explain WhyJul 23 2018, 17:30

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

test/

sigencoding_tests.cpp

41 lines

Diff 4379

src/test/sigencoding_tests.cpp

Loading...