src/test/sigencoding_tests.cpp
37 ↗	(On Diff #4306)	I see invalid checks for 0x00 and 0x05 and valid checks for 0x02, 0x03, 0x04. Please add a test for 0x01, as it's not covered in this test.

This revision now requires changes to proceed.Jul 16 2018, 19:11

Add test case starting with 0x01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2887: Diff 4328.Jul 16 2018, 22:46

jasonbcox accepted this revision.Jul 17 2018, 15:04

This revision is now accepted and ready to land.Jul 17 2018, 15:04

Closed by commit rABC81ee26544b1b: Add test for CheckPubKeyEncoding (authored by deadalnix). · Explain WhyJul 17 2018, 16:00

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

Makefile.test.include

1 line

test/

CMakeLists.txt

1 line

script_P2SH_tests.cpp

6 lines

script_tests.cpp

1 line

sigencoding_tests.cpp

150 lines

txvalidationcache_tests.cpp

2 lines

Diff 4336

View Options

src/Makefile.test.include

View Options

src/test/CMakeLists.txt

View Options

src/test/script_P2SH_tests.cpp

View Options

src/test/script_tests.cpp

View Options

src/test/sigencoding_tests.cpp

View Options

src/test/txvalidationcache_tests.cpp

Add test for CheckPubKeyEncodingClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 4336

src/Makefile.test.include

src/test/CMakeLists.txt

src/test/script_P2SH_tests.cpp

src/test/script_tests.cpp

src/test/sigencoding_tests.cpp

src/test/txvalidationcache_tests.cpp

Add test for CheckPubKeyEncoding
ClosedPublic
Actions

Revision Contents
Changeset List