Page MenuHomePhabricator

Add test for CheckPubKeyEncoding
ClosedPublic

Authored by deadalnix on Jul 15 2018, 00:59.

Details

Summary

As per title. More test is better.

Depends on D1565

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
sigencodingtest
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2872
Build 3848: Bitcoin ABC Buildbot (legacy)
Build 3847: arc lint + arc unit

Event Timeline

jasonbcox requested changes to this revision.Jul 16 2018, 19:11
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/test/sigencoding_tests.cpp
37

I see invalid checks for 0x00 and 0x05 and valid checks for 0x02, 0x03, 0x04. Please add a test for 0x01, as it's not covered in this test.

This revision now requires changes to proceed.Jul 16 2018, 19:11

Add test case starting with 0x01

This revision is now accepted and ready to land.Jul 17 2018, 15:04
This revision was automatically updated to reflect the committed changes.