Page MenuHomePhabricator

Refactor signature encoding checks to separates checks of the SigHashType and other checks
ClosedPublic

Authored by deadalnix on Jul 18 2018, 01:05.

Details

Summary

This is done via slicing the sig to remove the SigHashType. Hopefully, the next step is to expose an API to check signature without the SigHashType which will allow to reduce the test time dramatically.

Depends on D1577

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
checkwithsighash
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 2894
Build 3892: Bitcoin ABC Buildbot (legacy)
Build 3891: arc lint + arc unit

Event Timeline

Rename the funcion to CheckTransactionSignatureEncoding and add a doc comment.

Rename the function checking the signature itself into CheckRawSignatureEncoding

This revision is now accepted and ready to land.Jul 23 2018, 14:52
This revision was automatically updated to reflect the committed changes.