HomePhabricator

Merge #12561: Check for block corruption in ConnectBlock()

Description

Merge #12561: Check for block corruption in ConnectBlock()

Summary:
0e7c52d Shut down if trying to connect a corrupted block (Suhas Daftuar)

Pull request description:

(Updated OP after reworking the approach)

Shut down if a corrupted block is found in ConnectBlock().  This prevents an infinite loop trying to connect such a block, and alerts the node operator that there may be potential hardware failure.

Tree-SHA512: f20d56aa9d36d6eeff4c3d13c0fbd14f06a57701bd13c2416d36f0cc4235f81f752139e336a073617e8e803782c5096c960108af122b19a51227de512e9095ee

Backport of Core PR12561
https://github.com/bitcoin/bitcoin/pull/12561/

Test Plan:

make check
test_runner.py

Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc

Reviewed By: deadalnix, O1 Bitcoin ABC, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D3931

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on Apr 8 2018, 09:08
nakihitoCommitted on Aug 23 2019, 19:17
FabienPushed on Aug 26 2019, 09:42
Reviewer
Restricted Owners Package
Differential Revision
D3931: Merge #12561: Check for block corruption in ConnectBlock()
Parents
rSTAGINGe26ef4b479c4: Merge #11131: rpc: Write authcookie atomically
Branches
Unknown
Tags
Unknown