Page MenuHomePhabricator

Merge #12561: Check for block corruption in ConnectBlock()
ClosedPublic

Authored by nakihito on Wed, Aug 21, 20:13.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC546d8973648a: Merge #12561: Check for block corruption in ConnectBlock()
Summary

0e7c52d Shut down if trying to connect a corrupted block (Suhas Daftuar)

Pull request description:

(Updated OP after reworking the approach)

Shut down if a corrupted block is found in ConnectBlock().  This prevents an infinite loop trying to connect such a block, and alerts the node operator that there may be potential hardware failure.

Tree-SHA512: f20d56aa9d36d6eeff4c3d13c0fbd14f06a57701bd13c2416d36f0cc4235f81f752139e336a073617e8e803782c5096c960108af122b19a51227de512e9095ee

Backport of Core PR12561
https://github.com/bitcoin/bitcoin/pull/12561/

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Wed, Aug 21, 20:13
Owners added a reviewer: Restricted Owners Package.Wed, Aug 21, 20:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Aug 21, 20:13
deadalnix accepted this revision.Fri, Aug 23, 15:03
This revision is now accepted and ready to land.Fri, Aug 23, 15:03