Merge #12561: Check for block corruption in ConnectBlock()
ClosedPublic
Actions

Authored by nakihito on Aug 21 2019, 20:13.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING546d8973648a: Merge #12561: Check for block corruption in ConnectBlock()
rABC546d8973648a: Merge #12561: Check for block corruption in ConnectBlock()

Summary

0e7c52d Shut down if trying to connect a corrupted block (Suhas Daftuar)

Pull request description:

(Updated OP after reworking the approach)

Shut down if a corrupted block is found in ConnectBlock().  This prevents an infinite loop trying to connect such a block, and alerts the node operator that there may be potential hardware failure.

Tree-SHA512: f20d56aa9d36d6eeff4c3d13c0fbd14f06a57701bd13c2416d36f0cc4235f81f752139e336a073617e8e803782c5096c960108af122b19a51227de512e9095ee

Backport of Core PR12561
https://github.com/bitcoin/bitcoin/pull/12561/

Test Plan

make check
test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR12561

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7219
Build 12483: Bitcoin ABC Buildbot (legacy)
Build 12482: arc lint + arc unit

Event Timeline

nakihito created this revision.Aug 21 2019, 20:13

Owners added a reviewer: Restricted Owners Package.Aug 21 2019, 20:13

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 21 2019, 20:13

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7219: Diff 10915.Aug 21 2019, 20:20

Build Bitcoin-ABC / Diffs / Diff Testing passed.

deadalnix accepted this revision.Aug 23 2019, 15:03

This revision is now accepted and ready to land.Aug 23 2019, 15:03

Closed by commit rABC546d8973648a: Merge #12561: Check for block corruption in ConnectBlock() (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyAug 23 2019, 19:17

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABC546d8973648a: Merge #12561: Check for block corruption in ConnectBlock().

Nico Guiton <nico@bitframe.org> added a commit: rSTAGING546d8973648a: Merge #12561: Check for block corruption in ConnectBlock().Sep 19 2019, 01:59

Revision Contents
Changeset List

Path

Size

src/

validation.cpp

7 lines

Diff 10915

View Options

Merge #12561: Check for block corruption in ConnectBlock()ClosedPublicActions