HomePhabricator

Merge #11028: Avoid masking of difficulty adjustment errors by checkpoints

Description

Merge #11028: Avoid masking of difficulty adjustment errors by checkpoints

Summary:
85c82b5 Avoid masking of difficulty adjustment errors by checkpoints (Pieter Wuille)

Pull request description:

Currently difficulty adjustment violations are not reported for chains that branch off before the last checkpoint. Change this by moving the checkpoint check after the difficulty check.

Tree-SHA512: 33666f2c3459151b28c42041a463779e6df18f61d3dd5b1879a0af4e5b199ef74d1e33e06af68bebfdfb211569ad5fb56556bfebe9d63b5688d910ea211b839a

Backport of Core PR 11028
https://github.com/bitcoin/bitcoin/pull/11028/files
Depends on D2722

Test Plan:

make check
test_runner.py

Reviewers: deadalnix, Fabien, #bitcoin_abc

Reviewed By: Fabien, #bitcoin_abc

Subscribers: teamcity, schancel

Differential Revision: https://reviews.bitcoinabc.org/D2723

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on Aug 14 2017, 14:12
jasonbcoxCommitted on Mar 22 2019, 22:08
floreslorcaPushed on Mar 22 2019, 22:44
Reviewer
Restricted Project
Differential Revision
D2723: Merge #11028: Avoid masking of difficulty adjustment errors by checkpoints
Parents
rSTAGING9ae3baa3bba1: Add some release notes
Branches
Unknown
Tags
Unknown
References
tag: phabricator/base/7805, tag: phabricator/base/7802, tag: phabricator/base/7801