Page MenuHomePhabricator
Differential D2723

Merge #11028: Avoid masking of difficulty adjustment errors by checkpoints
ClosedPublic
Actions

Authored by jasonbcox on Mar 21 2019, 18:44.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING568a8f9c4b09: Merge #11028: Avoid masking of difficulty adjustment errors by checkpoints
rABC568a8f9c4b09: Merge #11028: Avoid masking of difficulty adjustment errors by checkpoints
Summary

85c82b5 Avoid masking of difficulty adjustment errors by checkpoints (Pieter Wuille)

Pull request description:

Currently difficulty adjustment violations are not reported for chains that branch off before the last checkpoint. Change this by moving the checkpoint check after the difficulty check.

Tree-SHA512: 33666f2c3459151b28c42041a463779e6df18f61d3dd5b1879a0af4e5b199ef74d1e33e06af68bebfdfb211569ad5fb56556bfebe9d63b5688d910ea211b839a

Backport of Core PR 11028
https://github.com/bitcoin/bitcoin/pull/11028/files
Depends on D2722

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Mar 21 2019, 18:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 21 2019, 18:44
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Mar 21 2019, 18:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Mar 21 2019, 18:59

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5267: Diff 7778.Mar 21 2019, 18:59
jasonbcox added inline comments.Mar 21 2019, 21:27
src/validation.cpp
3533 ↗(On Diff #7778)

This comment was missed as part of this backport: D1041 so adding it here.

jasonbcox updated this revision to Diff 7793.Mar 22 2019, 19:45

Rebase

teamcity added a comment.Mar 22 2019, 19:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5276: Diff 7793.Mar 22 2019, 20:00
teamcity added a comment.Mar 22 2019, 20:00

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien accepted this revision.Mar 22 2019, 20:37
This revision is now accepted and ready to land.Mar 22 2019, 20:37
Closed by commit rABC568a8f9c4b09: Merge #11028: Avoid masking of difficulty adjustment errors by checkpoints (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by jasonbcox). · Explain WhyMar 22 2019, 22:08
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rSTAGING568a8f9c4b09: Merge #11028: Avoid masking of difficulty adjustment errors by checkpoints.Sep 18 2019, 22:47

Revision Contents
Changeset List

PathSize
src/
88 lines

Diff 7800

View Options

src/validation.cpp

Loading...