Page MenuHomePhabricator

Merge #11028: Avoid masking of difficulty adjustment errors by checkpoints
ClosedPublic

Authored by jasonbcox on Mar 21 2019, 18:44.

Details

Summary

85c82b5 Avoid masking of difficulty adjustment errors by checkpoints (Pieter Wuille)

Pull request description:

Currently difficulty adjustment violations are not reported for chains that branch off before the last checkpoint. Change this by moving the checkpoint check after the difficulty check.

Tree-SHA512: 33666f2c3459151b28c42041a463779e6df18f61d3dd5b1879a0af4e5b199ef74d1e33e06af68bebfdfb211569ad5fb56556bfebe9d63b5688d910ea211b839a

Backport of Core PR 11028
https://github.com/bitcoin/bitcoin/pull/11028/files
Depends on D2722

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr11028
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5276
Build 8615: Bitcoin ABC Buildbot (legacy)
Build 8614: arc lint + arc unit

Event Timeline

src/validation.cpp
3533 ↗(On Diff #7778)

This comment was missed as part of this backport: D1041 so adding it here.

This revision is now accepted and ready to land.Mar 22 2019, 20:37