HomePhabricator

Merge #15013: test: Avoid race in p2p_timeouts

Description

Merge #15013: test: Avoid race in p2p_timeouts

Summary:
fabcd645b9 test: Avoid racy test p2p_timeouts (MarcoFalke)

Pull request description:

Avoid filesystem/network racyness by sleeping another second. The alternative would be to poll the `debug.log`, but that seems overkill to avoid a sleep in a test that already requires them.

Tree-SHA512: 32de75ecba38426323158fda241e37ffae73806d8c0e60b7ad73fb917e9cd25a3e5f0722cbc6f2f7a5b86501221c317783266bc2e3b4697fb120f05898ccc12d

Backport of Core PR15013

Depends on D5827

Test Plan:

test_runner.py p2p_timeouts  # run a few times

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D5828

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on Dec 21 2018, 19:19
jasonbcoxCommitted on Apr 24 2020, 22:31
majcostaPushed on Apr 24 2020, 23:30
Reviewer
Restricted Project
Differential Revision
D5828: Merge #15013: test: Avoid race in p2p_timeouts
Parents
rSTAGING2debdb2ce94c: Rename IsGood() to IsReliable()
Branches
Unknown
Tags
Unknown