Diffusion Bitcoin ABC staging 661d4af11a08

Declare single-argument (non-converting) constructors "explicit"
661d4af11a08
Actions

Description

Declare single-argument (non-converting) constructors "explicit"

Summary:
In order to avoid unintended implicit conversions.

Backport of core PR10969
Depends on D2205, D2206 and D2212

Test Plan:

make check

Reviewers: #bitcoin_abc, deadalnix, jasonbcox

Reviewed By: #bitcoin_abc, deadalnix, jasonbcox

Subscribers: jasonbcox, teamcity, schancel

Differential Revision: https://reviews.bitcoinabc.org/D2207

Details

Provenance

practicalswift <practicalswift@users.noreply.github.com>	Authored on Dec 21 2018, 11:40
Fabien	Committed on Dec 22 2018, 08:52
deadalnix	Pushed on Dec 22 2018, 16:44

Reviewer

Restricted Project

Differential Revision

D2207: Declare single-argument (non-converting) constructors "explicit"

Parents

rSTAGINGb36d97b25971: Merge #11638: [tests] Dead mininode code

Branches

Unknown

Tags

Unknown

References

tag: phabricator/base/6412, tag: phabricator/base/6409

Event Timeline

Fabien committed rSTAGING661d4af11a08: Declare single-argument (non-converting) constructors "explicit" (authored by practicalswift <practicalswift@users.noreply.github.com>).Dec 22 2018, 08:52

Changes (59)

Path

Size

src/

bench/

policy/

primitives/

qt/

paymentrequestplus.cpp

rpc/

script/

support/

test/

blockencodings_tests.cpp

validationinterface.cpp

versionbits.cpp

wallet/

test/

wallet_test_fixture.h

wallet.h

walletdb.h

rSTAGING661d4af11a08

View Options

src/addrdb.h

View Options

src/base58.cpp

View Options

src/bench/checkqueue.cpp

View Options

src/blockencodings.h

View Options

src/chain.h

View Options

src/compressor.h

View Options

src/cuckoocache.h

View Options

src/dbwrapper.h

View Options

src/hash.h

View Options

src/httprpc.cpp

View Options

src/httpserver.cpp

View Options

src/httpserver.h

View Options

src/init.cpp

View Options

src/limitedmap.h

View Options

src/miner.h

View Options

src/netaddress.h

View Options

src/netmessagemaker.h

View Options

src/policy/fees.h

View Options

src/primitives/block.h

View Options

src/primitives/transaction.h

View Options

src/protocol.h

View Options

src/pubkey.h

View Options

src/qt/coincontroldialog.h

View Options

src/qt/intro.cpp

View Options

src/qt/notificator.cpp

View Options

src/qt/overviewpage.cpp

View Options

src/qt/paymentrequestplus.cpp

View Options

src/qt/paymentserver.h

View Options

src/qt/utilitydialog.h

View Options

src/rest.cpp

View Options

src/reverse_iterator.h

View Options

src/rpc/mining.cpp

View Options

src/rpc/misc.cpp

View Options

src/rpc/server.h

View Options

src/scheduler.cpp

View Options

src/scheduler.h

View Options

src/script/sign.h

View Options

src/script/standard.cpp

View Options

src/serialize.h

View Options

src/support/lockedpool.h

View Options

src/test/base58_tests.cpp

View Options

src/test/bip32_tests.cpp

View Options

src/test/blockencodings_tests.cpp

View Options

src/test/coins_tests.cpp

View Options

src/test/dbwrapper_tests.cpp

View Options

src/test/test_bitcoin.h

View Options

src/tinyformat.h

View Options

src/torcontrol.cpp

View Options

src/txdb.cpp

View Options

src/txdb.h

View Options

src/txmempool.h

View Options

src/uint256.h

View Options

src/undo.h

View Options

src/validation.cpp

View Options

src/validationinterface.cpp

View Options

src/versionbits.cpp

View Options

src/wallet/test/wallet_test_fixture.h

View Options

src/wallet/wallet.h

View Options

Declare single-argument (non-converting) constructors "explicit"661d4af11a08Actions

Description

Details

Event Timeline

Changes (59)

rSTAGING661d4af11a08

src/addrdb.h

src/base58.cpp

src/bench/checkqueue.cpp

src/blockencodings.h

src/chain.h

src/compressor.h

src/cuckoocache.h

src/dbwrapper.h

src/hash.h

src/httprpc.cpp

src/httpserver.cpp

src/httpserver.h

src/init.cpp

src/limitedmap.h

src/miner.h

src/netaddress.h

src/netmessagemaker.h

src/policy/fees.h

src/primitives/block.h

src/primitives/transaction.h

src/protocol.h

src/pubkey.h

src/qt/coincontroldialog.h

src/qt/intro.cpp

src/qt/notificator.cpp

src/qt/overviewpage.cpp

src/qt/paymentrequestplus.cpp

src/qt/paymentserver.h

src/qt/utilitydialog.h

src/rest.cpp

src/reverse_iterator.h

src/rpc/mining.cpp

src/rpc/misc.cpp

src/rpc/server.h

src/scheduler.cpp

src/scheduler.h

src/script/sign.h

src/script/standard.cpp

src/serialize.h

src/support/lockedpool.h

src/test/base58_tests.cpp

src/test/bip32_tests.cpp

src/test/blockencodings_tests.cpp

src/test/coins_tests.cpp

src/test/dbwrapper_tests.cpp

src/test/test_bitcoin.h

src/tinyformat.h

src/torcontrol.cpp

src/txdb.cpp

src/txdb.h

src/txmempool.h

src/uint256.h

src/undo.h

src/validation.cpp

src/validationinterface.cpp

src/versionbits.cpp

src/wallet/test/wallet_test_fixture.h

src/wallet/wallet.h

src/wallet/walletdb.h

Declare single-argument (non-converting) constructors "explicit"
661d4af11a08
Actions