HomePhabricator

Declare single-argument (non-converting) constructors "explicit"

Description

Declare single-argument (non-converting) constructors "explicit"

Summary:
In order to avoid unintended implicit conversions.

Backport of core PR10969
Depends on D2205, D2206 and D2212

Test Plan:

make check

Reviewers: #bitcoin_abc, deadalnix, jasonbcox

Reviewed By: #bitcoin_abc, deadalnix, jasonbcox

Subscribers: jasonbcox, teamcity, schancel

Differential Revision: https://reviews.bitcoinabc.org/D2207

Details

Provenance
practicalswift <practicalswift@users.noreply.github.com>Authored on Dec 21 2018, 11:40
FabienCommitted on Dec 22 2018, 08:52
deadalnixPushed on Dec 22 2018, 16:44
Reviewer
Restricted Project
Differential Revision
D2207: Declare single-argument (non-converting) constructors "explicit"
Parents
rSTAGINGb36d97b25971: Merge #11638: [tests] Dead mininode code
Branches
Unknown
Tags
Unknown
References
tag: phabricator/base/6412, tag: phabricator/base/6409

Event Timeline