Page MenuHomePhabricator

Replace boost::adapter::reversed with custom reverse_iterator
ClosedPublic

Authored by Fabien on Dec 21 2018, 11:35.

Details

Summary

This removes the dependency to boost.
Based on core PR10193

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Dec 21 2018, 11:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 21 2018, 11:35
Herald added a subscriber: schancel. · View Herald Transcript
deadalnix requested changes to this revision.Dec 21 2018, 11:47
deadalnix added inline comments.
src/rwcollection.h
41 ↗(On Diff #6382)

Use ->

This revision now requires changes to proceed.Dec 21 2018, 11:47
Fabien updated this revision to Diff 6384.Dec 21 2018, 11:56

Replace (*a).b with a->b

deadalnix accepted this revision.Dec 21 2018, 11:57
This revision is now accepted and ready to land.Dec 21 2018, 11:57
Closed by commit rABC70d7755570d6: Replace boost::adapter::reversed with custom reverse_iterator (authored by Jorge Timón <jtimon@jtimon.cc>, committed by Fabien). · Explain WhyDec 21 2018, 12:08
This revision was automatically updated to reflect the committed changes.