HomePhabricator

Drop upgrade-cancel callback registration for a generic "cancelable"

Description

Drop upgrade-cancel callback registration for a generic "cancelable"

Summary:
Instead of passing a StartShutdown reference all the way up from txdb,
give ShowProgress a "cancelable" boolean, as StartShutdown is pretty
much always what you'll want to use to cancel. Use the same boolean to
allow cancel during initial block verification.

Backport of core PR10770

Completes task T511

Test Plan:

make check

Start bitcoin-qt and cancel at splashscreen by pressing 'q'

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: teamcity, schancel

Differential Revision: https://reviews.bitcoinabc.org/D2476

Details

Provenance
Matt Corallo <git@bluematt.me>Authored on Feb 1 2019, 10:53
FabienCommitted on Feb 1 2019, 20:43
markblundebergPushed on Feb 1 2019, 23:10
Reviewer
Restricted Project
Differential Revision
D2476: Drop upgrade-cancel callback registration for a generic "cancelable"
Parents
rSTAGING176af7cb6d46: Remove trailing space in logging.cpp
Branches
Unknown
Tags
Unknown