Page MenuHomePhabricator

Drop upgrade-cancel callback registration for a generic "cancelable"
ClosedPublic

Authored by Fabien on Feb 1 2019, 11:16.

Details

Summary

Instead of passing a StartShutdown reference all the way up from txdb,
give ShowProgress a "cancelable" boolean, as StartShutdown is pretty
much always what you'll want to use to cancel. Use the same boolean to
allow cancel during initial block verification.

Backport of core PR10770

Completes task T511

Test Plan
make check

Start bitcoin-qt and cancel at splashscreen by pressing 'q'

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Feb 1 2019, 11:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 1 2019, 11:16
Herald added a subscriber: schancel. · View Herald Transcript
deadalnix accepted this revision.Feb 1 2019, 16:57
This revision is now accepted and ready to land.Feb 1 2019, 16:57
This revision was automatically updated to reflect the committed changes.