HomePhabricator

fix fee estimation bug in functional tests

Description

fix fee estimation bug in functional tests

Summary:
D1926 introduced this magic number of 81 which doesn't seem to have any
justification (it's definitely larger than any signature can possibly be),
It looks like it was a rushed fix to the CI.

This number was actually too small, and dbcrash only ended up working
because of the fLimitFree being disabled for rpc-submitted transactions.

Test Plan:

test_runner.py --extended

Reviewers: jasonbcox, #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D4729

Details

Provenance
Mark Lundeberg <markblundeberg@users.noreply.github.com>Authored on Dec 15 2019, 08:12
FabienPushed on Dec 17 2019, 07:42
Reviewer
Restricted Project
Differential Revision
D4729: fix fee estimation bug in functional tests
Parents
rSTAGING5aede8279a63: fix some tests that misuse MANDATORY_SCRIPT_VERIFY_FLAGS
Branches
Unknown
Tags
Unknown