Page MenuHomePhabricator
Differential D4729

fix fee estimation bug in functional tests
ClosedPublic
Actions

Authored by markblundeberg on Dec 15 2019, 08:14.

Details

Reviewers
jasonbcox
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING8e630eb8f3c5: fix fee estimation bug in functional tests
rABC8e630eb8f3c5: fix fee estimation bug in functional tests
Summary

D1926 introduced this magic number of 81 which doesn't seem to have any
justification (it's definitely larger than any signature can possibly be),
It looks like it was a rushed fix to the CI.

This number was actually too small, and dbcrash only ended up working
because of the fLimitFree being disabled for rpc-submitted transactions.

Test Plan
test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markblundeberg created this revision.Dec 15 2019, 08:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 15 2019, 08:14
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Dec 15 2019, 08:15

Build Bitcoin-ABC / Diffs / Diff Testing started.

markblundeberg added a child revision: D4730: ensure RPC calls AcceptToMemoryPool using same fee policy as net.Dec 15 2019, 08:16
teamcity added a comment.Dec 15 2019, 08:28

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8564: Diff 14865.Dec 15 2019, 08:28
markblundeberg added a comment.Dec 15 2019, 09:11

(see D4730 which exposed this discrepancy)

deadalnix accepted this revision.Dec 16 2019, 13:23
This revision is now accepted and ready to land.Dec 16 2019, 13:23
Closed by commit rABC8e630eb8f3c5: fix fee estimation bug in functional tests (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>). · Explain WhyDec 17 2019, 03:21
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rABC8e630eb8f3c5: fix fee estimation bug in functional tests.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rSTAGING8e630eb8f3c5: fix fee estimation bug in functional tests.Apr 7 2020, 22:05

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
15 lines

Diff 14894

View Options

test/functional/test_framework/test_node.py

Loading...