HomePhabricator

Do not increase the banscore of node forwarding transactions that are not valid…
a4459140a0d5Unpublished

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

Do not increase the banscore of node forwarding transactions that are not valid yet.

Summary: This causes a risk of node banning legitimate peers during inintial sync if that peer relays a lot of transactions. Hopefully the banscore increase is not too high so the practical impact is not huge, but it is still worth fixing.

Test Plan:

make check
../qa/pull-tester/rpc-tests.py

Reviewers: freetrader, awemany, sickpig, kyuupichan, #bitcoin_abc

Reviewed By: freetrader, awemany, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D385

Details

Provenance
deadalnixAuthored on Jul 27 2017, 11:45
schancelPushed on Jan 5 2018, 21:58
schancelPushed on Jan 5 2018, 21:39
schancelPushed on Jan 5 2018, 21:17
Reviewer
Restricted Project
Differential Revision
D385: Do not increase the banscore of node forwarding transactions that are not valid yet.
Parents
rSTAGING4fd05d5377d4: Update various debian packaging files
Branches
Unknown
Tags
Unknown