Do not increase the banscore of node forwarding transactions that are not valid yet.
ClosedPublic
Actions

Authored by deadalnix on Jul 27 2017, 12:01.

Details

Reviewers

freetrader
awemany
sickpig
kyuupichan

Group Reviewers

Restricted Project

Commits

rSTAGINGa4459140a0d5: Do not increase the banscore of node forwarding transactions that are not valid…
rABCa4459140a0d5: Do not increase the banscore of node forwarding transactions that are not valid…

Summary

This causes a risk of node banning legitimate peers during inintial sync if that peer relays a lot of transactions. Hopefully the banscore increase is not too high so the practical impact is not huge, but it is still worth fixing.

Test Plan

make check
../qa/pull-tester/rpc-tests.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Jul 27 2017, 12:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 27 2017, 12:01

Harbormaster completed remote builds in B598: Diff 959.Jul 27 2017, 12:01

freetrader added inline comments.Jul 27 2017, 12:31

src/validation.cpp
655 ↗	(On Diff #959)	scoreban -> ban score

ban score

LGTM

make check runs successfully

src/validation.cpp
655 ↗	(On Diff #959)	The comment being below the code that's executed confused the heck out of me. Should be above the call to ContextualCheckTransactionForCurrentBlock(...)