Page MenuHomePhabricator

Do not increase the banscore of node forwarding transactions that are not valid yet.
ClosedPublic

Authored by deadalnix on Jul 27 2017, 12:01.

Details

Summary

This causes a risk of node banning legitimate peers during inintial sync if that peer relays a lot of transactions. Hopefully the banscore increase is not too high so the practical impact is not huge, but it is still worth fixing.

Test Plan
make check
../qa/pull-tester/rpc-tests.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
nobanscorefinal
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 598
Build 598: arc lint + arc unit

Event Timeline

src/validation.cpp
655

scoreban -> ban score

make check runs successfully

src/validation.cpp
655

The comment being below the code that's executed confused the heck out of me. Should be above the call to ContextualCheckTransactionForCurrentBlock(...)

This revision is now accepted and ready to land.Jul 27 2017, 13:05
This revision was automatically updated to reflect the committed changes.