HomePhabricator

net, doc: Doxygen updates and fixes in netbase.{h,cpp}

Description

net, doc: Doxygen updates and fixes in netbase.{h,cpp}

Summary:

net: update incorrect Doxygen documentation in netbase.cpp

net: move Doxygen docs from netbase.cpp to netbase.h

This is a backport of core#21444

Notes :

  • the third commit is not applicable due to D11042 (replacement of SOCKET &hSocketRet with Sock &sock in the function signature).
  • the doxygen doc for Socks5 cannot be moved because we didn't backport core#19203, so it is still a static function not defined in the header.

Depends on D11067

Test Plan:
Compile to make sure no code was accidentaly broken and unnoticed.

Proofreading

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D11069

Details

Provenance
PiRKAuthored on Feb 18 2022, 10:39
jasonbcoxPushed on Feb 21 2022, 13:23
Parents
rSTAGING83a625be647d: net: Make DNS lookup code testable
Branches
Unknown
Tags
Unknown

Event Timeline